Implement Feature types #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeyboardNerd
changed the title
KeyboardNerd
changed the title
KeyboardNerd
changed the title
KeyboardNerd
changed the title
KeyboardNerd
force-pushed
the
source_package/feature_type
branch
2 times, most recently
from
bd4a4ec
to
a42632d
Compare
feature_type is for differentiating the binary packages and source packages.
KeyboardNerd
force-pushed
the
source_package/feature_type
branch
from
761cc3e
to
a770585
Compare
KeyboardNerd
commented
Feb 19, 2019
| @@ -1,26 +0,0 @@ | |||
| // Copyright 2018 clair authors | |||
There was a problem hiding this comment.
This is renamed to database/feature_type.go
|
|
||
| // ErrMissingEntities is an error that occurs when an associated immutable | ||
| // entity doesn't exist in the database. This error can indicate a wrong | ||
| // implementation or corrupted database. | ||
| ErrMissingEntities = errors.New("database: associated immutable entities are missing in the database") | ||
| ErrMissingEntities = NewStorageError("associated immutable entities are missing in the database") |
There was a problem hiding this comment.
one by one we're moving to use special error type for the database.
| @@ -155,18 +155,33 @@ type Namespace struct { | |||
| VersionFormat string | |||
| } | |||
|
|
|||
| func NewNamespace(name string, versionFormat string) *Namespace { | |||
There was a problem hiding this comment.
we're moving to use the proper initializer for the database structs
|
|
||
| fmt.Printf("%d features, %d vulnerabilities are generated", len(nsFeatures), len(vulnerabilities)) |
There was a problem hiding this comment.
Remove the concurrent insertion because the vulnerabilities <-> feature relationships are cached after the features are inserted into the database
The featurefmt now extracts both binary packages and source packages from the package manager infos.
Remove source name/version fields Add Type field to indicate if it's binary package or source package
postgres 9.4 doesn't support ON CONFLICT, which is required in our implementation.
KeyboardNerd
force-pushed
the
source_package/feature_type
branch
from
a770585
to
870e812
Compare
API now returns every feature found by the detectors and also indicates the type of feature.
jzelinskie
suggested changes
Feb 19, 2019
| @@ -179,6 +194,11 @@ type NamespacedFeature struct { | |||
| Namespace Namespace | |||
| } | |||
|
|
|||
| func NewNamespacedFeature(namespace *Namespace, feature *Feature) *NamespacedFeature { | |||
| // TODO: namespaced feature should use pointer values | |||
There was a problem hiding this comment.
Is it only desirable to use pointers here to save memory?
There was a problem hiding this comment.
I think it's idiomatic to use the pointer value for structs
jzelinskie
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is to differentiate packages by their types, and vulnerabilities to affect different types of features.
Change set:
Feature Detectors: Extract both binary and source packages from image layers
Vulnerability matching algorithm change: Each vulnerability matches a specific type of package, either binary or source package.
Please correct the above assumption for each vulnerability data source if any error.
For each Feature, we add a field to indicate the type of the feature, currently it's Binary or Source package.