Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clair: orderly shutdown #2015

Merged
merged 4 commits into from
Jul 23, 2024
Merged

clair: orderly shutdown #2015

merged 4 commits into from
Jul 23, 2024

Conversation

hdonnay
Copy link
Member

@hdonnay hdonnay commented Mar 22, 2024

Closes #1946

@hdonnay hdonnay requested a review from a team as a code owner March 22, 2024 15:07
@hdonnay hdonnay requested review from crozzy and removed request for a team March 22, 2024 15:07
@hdonnay
Copy link
Member Author

hdonnay commented Mar 22, 2024 •
edited
Loading

Needs CI updates; working on those. Done

@hdonnay
Copy link
Member Author

hdonnay commented Apr 17, 2024

Not sure if there's a good way to cook up a test for this?

@hdonnay
clair: redo shutdown structure
b0086d8 
This changes the incorrect-but-at-least-stops implementation with a
little tree of goroutines.

The full fix requires `context.WithoutCancel`, which we can't quite use
yet.

Closes: quay#1946
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
clair: break cancellation chain for request contexts
76a5d50 
This means that the request contexts should now only be able to be
cancelled via the `(http.Server).Shutdown`/`(http.Server).Close`
methods.

Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
introspection: allow trace shutdown hook full timeout
8e1a7bd 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
clair: add platform-specific signals
ba6fc37 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay
Copy link
Member Author

hdonnay commented Jul 23, 2024

ping @crozzy

crozzy
crozzy reviewed Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@crozzy crozzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of questions

introspection/server.go Show resolved Hide resolved
cmd/clair/main.go Show resolved Hide resolved
@hdonnay hdonnay requested a review from crozzy July 23, 2024 18:57
@hdonnay
Copy link
Member Author

hdonnay commented Jul 23, 2024

/fast-forward

@github-actions github-actions bot merged commit ba6fc37 into quay:main Jul 23, 2024
13 checks passed
@hdonnay hdonnay deleted the bug/shutdown-1_22 branch July 23, 2024 19:44
@hdonnay hdonnay mentioned this pull request Jul 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crozzy crozzy crozzy approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Graceful shutdown ... isn't
2 participants
@hdonnay @crozzy