Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check manifest to check index report #1131

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Check manifest to check index report #1131

wants to merge 2 commits into from

Commits on Oct 31, 2023

  1. indexer: Remove retry logic 

    The retry logic in the indexer's controller is faulty in that every action that may return a timeout error (the entry path to set retry to true) will also return a Terminal state along with the timeout error.  Therefore after pausing briefly in the retry statement it will then break due to the next state being Terminal. I think the correct way to fix this is to just remove the rety logic as it can also cause an empty index report to be written to the database and simplifying the code seems to be the best approach.

Signed-off-by: Iain Duncan <iain.duncan@uk.ibm.com>
    @iainduncani
    iainduncani committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    ffed2b8 View commit details
    Browse the repository at this point in the history

  2. indexer: Reprocess unfinished index reports 

    If a manifest has scanned with all it's scanners it _should_ end up with a completed index report in the IndexFinished state.  If it does not then it will not be possible to query this manifest.  To fix an incomplete index report it will need rescanning so trigger a rescan.

Signed-off-by: Iain Duncan <iain.duncan@uk.ibm.com>
    @iainduncani
    iainduncani committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    8af9f43 View commit details
    Browse the repository at this point in the history