matcher: Introduce Remote Matcher interface #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemoteMatcher is an additional interface that a Matcher can implement. When called the interface can invoke the remote matcher using the RESTful API to fetch new vulnerabilities associated with the given IndexRecords. The information retrieved from this interface **won't be persisted** into ClairCore database.
arajkumar
requested review from
alecmerdler,
hdonnay,
jzelinskie and
ldelossa
as code owners
|
arajkumar#3 is a WIP PR which implements the RemoteMatcher to fetch Python vulnerabilities from CRDA platform. |
arajkumar
changed the title
ldelossa
suggested changes
Jul 16, 2020
Co-authored-by: Louis DeLosSantos <louis.delos@gmail.com>
arajkumar
force-pushed
the
remote-matcher-v1
branch
from
26d2bfa
to
acb6bb4
Compare
ldelossa
approved these changes
Jul 16, 2020
4 tasks
arajkumar
added a commit
to arajkumar/claircore
that referenced
this pull request
Jul 20, 2020
* matcher: Add preliminary support for Remote Matcher RemoteMatcher is an additional interface that a Matcher can implement. When called the interface can invoke the remote matcher using the RESTful API to fetch new vulnerabilities associated with the given IndexRecords. The information retrieved from this interface **won't be persisted** into ClairCore database. * Update internal/matcher/controller.go Co-authored-by: Louis DeLosSantos <louis.delos@gmail.com> * remotematcher: Add a realistic deadline for QueryRemoteMatcher call * remotematcher: Change deadline to 60s according to review comments Co-authored-by: Louis DeLosSantos <louis.delos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RemoteMatcher is an additional interface that a Matcher can implement.
When called the interface can invoke the remote matcher using the RESTful API
to fetch new vulnerabilities associated with the given IndexRecords.
The information retrieved from this interface won't be persisted into ClairCore database.