Backport 0.4: java #440
Merged
Backport 0.4: java #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in the OCI image spec[1], whiteout files are used to indicate file or directory removals. The jar scanner was not considering file prefixes and instead only looking at the suffixes. [1]: https://github.com/opencontainers/image-spec/blob/master/layer.md#representing-changes Backports: quay#409 Signed-off-by: Hank Donnay <hdonnay@redhat.com>
This change looks at the magic number if something appears to be a jar based on the filename. Backports: quay#435 Signed-off-by: Hank Donnay <hdonnay@redhat.com>
hdonnay
requested review from
alecmerdler,
jzelinskie and
ldelossa
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports java fixes.