dockerfile: fix terminal expansion with too-small destination #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a corner-case where the transformer would consume some input, begin expansion, then need to signal for more space and lose track of what it had consumed. I added an explicit state to signal that the transformer should immediately try to expand, and then modified the return path of the corner case to use that state. Closes: PROJQUAY-2765 Signed-off-by: Hank Donnay <hdonnay@redhat.com>
crozzy
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a corner-case where the transformer would consume some input,
begin expansion, then need to signal for more space and lose track of
what it had consumed. I added an explicit state to signal that the
transformer should immediately try to expand, and then modified the
return path of the corner case to use that state.
Closes: PROJQUAY-2765
Signed-off-by: Hank Donnay hdonnay@redhat.com