-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jar: Deal with non-sane manifests without erroring #523
Conversation
These errors are mildly common in production:
|
Tooling around with the ways to create JARs I haven't able to reproduce or find a wild manifest without |
88e39ce
to
d3149f3
Compare
Another error that would potentially be addressed with this
|
d3149f3
to
7468d01
Compare
30de2bd
to
41f2fc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'd change the key in that one log line, but that's not a blocker.
This is an error seen in the wild where an META-INF/MANIFEST.MF file does not contain the Manifest-Version. Currently this will cause an indexing failure (and a 500 response). Signed-off-by: crozzy <joseph.crosland@gmail.com>
41f2fc1
to
ea82e32
Compare
This is an error seen in the wild where an META-INF/MANIFEST.MF
file does not contain the Manifest-Version. Currently this will
cause an indexing failure (and a 500 response).
Signed-off-by: crozzy joseph.crosland@gmail.com