pep440: log the invalid version string #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
quay.io/crozzy/test-py:bad-version2 Test image |
crozzy
force-pushed
the
crozzy-python-version-changes
branch
4 times, most recently
from
8b314ba
to
6762103
Compare
hdonnay
previously approved these changes
Dec 6, 2021
crozzy
force-pushed
the
crozzy-python-version-changes
branch
from
6762103
to
1dca7d5
Compare
We observed that the python scanner can cause the indexing to fail due to a bad version being passed. This PR logs the bad version and moves on to other potential packages. We assume the offending package is un-addressable. Signed-off-by: crozzy <joseph.crosland@gmail.com>
crozzy
force-pushed
the
crozzy-python-version-changes
branch
from
1dca7d5
to
9a02070
Compare
hdonnay
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When debugging it would be nice to see the strings that are
choking during the version parsing to be able to add them to
regressions.
Signed-off-by: crozzy joseph.crosland@gmail.com