Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dpkg: Add distroless scanner #758

Merged
merged 1 commit into from
Feb 9, 2023
Merged

dpkg: Add distroless scanner #758

merged 1 commit into from
Feb 9, 2023

Conversation

crozzy
Copy link
Contributor

@crozzy crozzy commented Dec 9, 2022

This change adds a distroless scanner which is in itself a different flavour of dpkg scanner. It reads the dpkg files found in the var/lib/dpkg/status.d/ directory.

Signed-off-by: crozzy joseph.crosland@gmail.com

@crozzy
Copy link
Contributor Author

crozzy commented Dec 14, 2022

closes quay/clair#1598

@crozzy
Copy link
Contributor Author

crozzy commented Jan 6, 2023

related to #181

@crozzy crozzy marked this pull request as ready for review January 6, 2023 19:44
@crozzy crozzy requested a review from a team as a code owner January 6, 2023 19:44
@crozzy crozzy requested review from hdonnay and removed request for a team January 6, 2023 19:44
@hdonnay hdonnay added the needs-changelog Label for PRs that need a changelog note. label Jan 9, 2023
dpkg/distroless_scanner.go Outdated Show resolved Hide resolved
dpkg/distroless_scanner.go Outdated Show resolved Hide resolved
dpkg/distroless_scanner.go Outdated Show resolved Hide resolved
dpkg/distroless_scanner.go Outdated Show resolved Hide resolved
dpkg/distroless_scanner.go Outdated Show resolved Hide resolved
@crozzy crozzy force-pushed the distroless branch 2 times, most recently from fc55bcd to 614ff55 Compare February 2, 2023 23:27
dpkg/distroless_scanner.go Outdated Show resolved Hide resolved
dpkg/distroless_scanner.go Outdated Show resolved Hide resolved
dpkg/distroless_scanner.go Outdated Show resolved Hide resolved
@crozzy crozzy force-pushed the distroless branch 2 times, most recently from bd02bf4 to 849d233 Compare February 6, 2023 19:19
dpkg/distroless_scanner.go Show resolved Hide resolved
dpkg/distroless_scanner.go Show resolved Hide resolved
RTann
RTann previously approved these changes Feb 6, 2023
dpkg/distroless_scanner.go Show resolved Hide resolved
@crozzy crozzy requested a review from hdonnay February 8, 2023 21:35
hdonnay
hdonnay previously approved these changes Feb 9, 2023
Copy link
Member

@hdonnay hdonnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending rebase

This change adds a distroless scanner which is in itself a different
flavour of dpkg scanner. It reads the dpkg files found in the
var/lib/dpkg/status.d/ directory.

Signed-off-by: crozzy <joseph.crosland@gmail.com>
@hdonnay hdonnay dismissed stale reviews from RTann and themself via f1cd174 February 9, 2023 16:30
@hdonnay hdonnay linked an issue Feb 9, 2023 that may be closed by this pull request
@hdonnay hdonnay merged commit f1cd174 into quay:main Feb 9, 2023
@hdonnay hdonnay removed the needs-changelog Label for PRs that need a changelog note. label Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported scan results on Google Distroless images
3 participants