Louis/dedupe vulns remodel #93

ldelossa · 2019-12-27T13:59:37Z

This PR accomplishes the following:

Creates a new model called "Environment". This model allows a single unique package to be found in multiple Environment contexts. While an edge case for linux systems, this model is necessary for language package scanning where an indexed Python package can be found several times in multiple PIP databases (in the python example).
Removes the vulnscanner, it was crufty and out of place, in favor of a single Match method in the matcher package
Refactor the linux.Coalescer and heavily comment our algorithm for matching packages with their environment.

debian/matcher_integration_test.go

internal/indexer/linux/coalescer.go

internal/indexer/controller/coalesce.go

internal/indexer/linux/coalescer_test.go

rhel/matcher_test.go

vulnerabilityreport.go

internal/matcher/match.go

hdonnay

LGTM

ldelossa requested review from hdonnay and jzelinskie as code owners December 27, 2019 13:59

ldelossa force-pushed the louis/dedupe-vulns-remodel branch from 301e6b0 to 1786cee Compare January 3, 2020 15:51

ldelossa added 7 commits January 6, 2020 15:52

match function, remove vulnscanner

a846b25

update tests and docs

df5a4e2

copy pointer to avoid overwriting fixed in

9a0869f

support packages in multiple dbs

d489b34

remove slow ubuntu tests

ac25d09

Remodal into environments

4e1f32b

distID null check and test

f61d5ea

ldelossa force-pushed the louis/dedupe-vulns-remodel branch from 1786cee to f61d5ea Compare January 6, 2020 20:53

hdonnay requested changes Jan 6, 2020

View reviewed changes

ldelossa added 2 commits January 7, 2020 10:32

update indexreports in tests

cb28b5f

code review changes

635f5e3

hdonnay approved these changes Jan 7, 2020

View reviewed changes

ldelossa merged commit 27ade1d into master Jan 8, 2020

ldelossa deleted the louis/dedupe-vulns-remodel branch February 28, 2020 20:17

Provide feedback