Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to Quay image 3.7.0 (PROJQUAY-3867) #65

Merged
merged 1 commit into from May 27, 2022

Conversation

bcaton85
Copy link
Contributor

Upgrading the Quay image to use 3.7.0.

@@ -253,6 +253,7 @@ func getImageMetadata(app, imageName, archivePath string) string {
--change 'ENV LANG=en_US.utf8' \
--change 'ENV QUAYDIR=/quay-registry' \
--change 'ENV QUAYCONF=/quay-registry/conf' \
--change 'ENV QUAYRUN=/quay-registry/conf' \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this line needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quay will fail to startup. It's referenced in a systemd template and if it isn't set the templating fails. I believe it was recently introduced.

@HammerMeetNail HammerMeetNail added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 26, 2022
@HammerMeetNail HammerMeetNail added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels May 26, 2022
@HammerMeetNail
Copy link
Contributor

Removing community.crypto looks to resolve the install issue, not sure why CI is failing. I'm able to build and install on a test VM using this branch. Retriggering CI and watching VMs....

@HammerMeetNail
Copy link
Contributor

Seeing this error in the quay-app logs on the remote offline host:

Running init script '/quay-registry/conf/init/supervisord_conf_create.sh'
Running init script '/quay-registry/conf/init/zz_boot.sh'
/quay-registry/data/secscan_model/__init__.py:28: DeprecationWarning: Call to deprecated class V2SecurityScanner. (Will be replaced by a V4 API security scanner soon)
  self._legacy_model = V2SecurityScanner(app, instance_keys, storage)
Failed to validate security scanner V2 configuration
/quay-registry/data/secscan_model/__init__.py:30: DeprecationWarning: Call to deprecated class NoopV2SecurityScanner. (Will be replaced by a V4 API security scanner soon)
  self._legacy_model = NoopV2SecurityScanner()
Generated new service key ZpqCzX8CPvzPuRmEjfa0-hEfaZiWIljqsNOc4J-ds70
Error: Format string '%(ENV_QUAYRUN)s/supervisord.sock' for 'unix_http_server.file' contains names ('ENV_QUAYRUN') which cannot be expanded. Available names: ENV_CONFIG_APP_PASSWORD, ENV_DB_CONNECTION_POOLING_REGISTRY, ENV_HOME, ENV_HOSTNAME, ENV_LANG, ENV_LC_CTYPE, ENV_OPERATOR_ENDPOINT, ENV_PATH, ENV_PWD, ENV_PYTHONIOENCODING, ENV_PYTHONUNBUFFERED, ENV_PYTHON_ROOT, ENV_PYTHON_VERSION, ENV_QUAYCONF, ENV_QUAYDIR, ENV_QUAYPATH, ENV_QUAY_CONFIG_READ_ONLY_FIELD_GROUPS, ENV_RED_HAT_QUAY, ENV_SHLVL, ENV_TERM, ENV_container, here
For help, use /usr/local/bin/supervisord -h

@bcaton85
Copy link
Contributor Author

That should have been resolved by adding the QUAYRUN env var to this line. Is it missing somewhere else? That's the only place i had to add it for my tests.

@HammerMeetNail HammerMeetNail added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels May 27, 2022
@HammerMeetNail
Copy link
Contributor

That should have been resolved by adding the QUAYRUN env var to this line. Is it missing somewhere else? That's the only place i had to add it for my tests.

Maybe here:

cmd: podman image import --change 'ENV PATH=/.local/bin/:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin' --change 'ENV RED_HAT_QUAY=true' --change 'ENV PYTHON_VERSION=3.8' --change 'ENV PYTHON_ROOT=/usr/local/lib/python3.8' --change 'ENV PYTHONUNBUFFERED=1' --change 'ENV PYTHONIOENCODING=UTF-8' --change 'ENV LANG=en_US.utf8' --change 'ENV QUAYDIR=/quay-registry' --change 'ENV QUAYCONF=/quay-registry/conf' --change 'ENV QUAYRUN=/quay-registry/conf' --change 'ENV QUAYPATH=.' --change 'ENV container=oci' --change 'ENTRYPOINT=["dumb-init","--","/quay-registry/quay-entrypoint.sh"]' --change 'WORKDIR=/quay-registry' --change 'EXPOSE=7443' --change 'EXPOSE=8080' --change 'EXPOSE=8443' --change 'VOLUME=/conf/stack' --change 'VOLUME=/datastorage' --change 'VOLUME=/tmp' --change 'VOLUME=/var/log' --change 'USER=1001' --change 'CMD ["registry"]' - {{ quay_image }} < {{ quay_root }}/quay.tar

Just pushed up a change and triggered CI

@HammerMeetNail HammerMeetNail added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels May 27, 2022
@HammerMeetNail HammerMeetNail added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels May 27, 2022
@HammerMeetNail HammerMeetNail added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels May 27, 2022
Upgrading the Quay image to use 3.7.0.

Signed-off-by: Dave O'Connor <doconnor@redhat.com>
@HammerMeetNail HammerMeetNail added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels May 27, 2022
Copy link
Contributor

@HammerMeetNail HammerMeetNail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@HammerMeetNail HammerMeetNail merged commit e95bf17 into quay:main May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Development

Successfully merging this pull request may close these issues.

None yet

3 participants