Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup in reverse order from startup (PROJQUAY-4629) #93

Merged
merged 1 commit into from Nov 16, 2022

Conversation

dmc5179
Copy link
Contributor

@dmc5179 dmc5179 commented Sep 27, 2022

Stop services in reverse order, then remove quay root and systemd unit files and reload systemd

@HammerMeetNail HammerMeetNail added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 17, 2022
@HammerMeetNail HammerMeetNail changed the title Cleanup in reverse order from startup Cleanup in reverse order from startup (PROJQUAY-4629) Oct 17, 2022
@HammerMeetNail
Copy link
Contributor

HammerMeetNail commented Oct 17, 2022

@dmc5179 Looks like the name change from quay-app to quay-postgress breaks install on local installations. Can you update the PR to address this?

fatal: [jonathan@mirror-ci-rhel-local-offline-install.c.quay-devel.internal]: FAILED! => ***"attempts": 20, "changed": true, "cmd": ["podman", "exec", "-it", "quay-postgres", "/bin/bash", "-c", "echo 'CREATE EXTENSION IF NOT EXISTS pg_trgm' | psql -d quay -U postgres"], "delta": "0:00:00.058352", "end": "2022-10-17 17:05:21.292428", "msg": "non-zero return code", "rc": 125, "start": "2022-10-17 17:05:21.234076", "stderr": "Error: no container with name or ID \"quay-postgres\" found: no such container", "stderr_lines": ["Error: no container with name or ID \"quay-postgres\" found: no such container"], "stdout": "", "stdout_lines": []***

Update
Huh, I might be wrong, I'm seeing this error in other builds. Looking closer...

@HammerMeetNail
Copy link
Contributor

Found the issue, it's related to the pause image we're using. I've made the update here. Once this is merged, can you rebase and we'll get this in? #94

@HammerMeetNail HammerMeetNail added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Nov 16, 2022
Copy link
Contributor

@HammerMeetNail HammerMeetNail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HammerMeetNail HammerMeetNail merged commit ea30d5e into quay:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Development

Successfully merging this pull request may close these issues.

None yet

3 participants