chore: remove reflection zero type when zero value is known

Topic: rm-reflection Relative: projquay-6620 Signed-off-by: Ross Bryan <robryan@redhat.com>
quay · Feb 28, 2024 · 7fd04c7 · 7fd04c7
1 parent c39e6d2
commit 7fd04c7
Show file tree

Hide file tree

Showing 3 changed files with 240 additions and 8 deletions.
diff --git a/pkg/client/quay/client.go b/pkg/client/quay/client.go
@@ -8,8 +8,7 @@ import (
 	"io/ioutil"
 	"net/http"
 	"net/url"
-
-	"github.com/quay/quay-bridge-operator/pkg/utils"
+	"strings"
 )
 
 type QuayClient struct {
@@ -172,7 +171,7 @@ func (c *QuayClient) newRequest(method, path string, body interface{}) (*http.Re
 	}
 
 	req, err := http.NewRequest(method, u.String(), buf)
-	if !utils.IsZeroOfUnderlyingType(c.AuthToken) {
+	if !strings.EqualFold("", c.AuthToken) {
 		req.Header.Set("Authorization", "Bearer "+c.AuthToken)
 	}
 

diff --git a/pkg/client/quay/mocks/client_mock.go b/pkg/client/quay/mocks/client_mock.go
diff --git a/pkg/utils/utils.go b/pkg/utils/utils.go
@@ -2,17 +2,12 @@ package utils
 
 import (
 	"fmt"
-	"reflect"
 
 	"github.com/quay/quay-bridge-operator/pkg/constants"
 	"github.com/quay/quay-bridge-operator/pkg/logging"
 	corev1 "k8s.io/api/core/v1"
 )
 
-func IsZeroOfUnderlyingType(x interface{}) bool {
-	return reflect.DeepEqual(x, reflect.Zero(reflect.TypeOf(x)).Interface())
-}
-
 func RemoveItemsFromSlice(s []string, r []string) []string {
 
 	for i, v := range s {