Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove namespace from build output (PROJQUAY-2898) #41

Merged
merged 1 commit into from Feb 3, 2022

Conversation

ttaylor249
Copy link
Contributor

This fixes #39 so that Build resources mutated by the operator pass validation after the modifications are applied.

@harishsurf
Copy link
Contributor

/retest

Copy link
Contributor

@harishsurf harishsurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed the namespace field is omitted for DockerImage type (source).

Thanks for the PR, lgtm!

@harishsurf
Copy link
Contributor

/cherrypick redhat-3.6

@openshift-cherrypick-robot
Copy link
Collaborator

@harishsurf: once the present PR merges, I will cherry-pick it on top of redhat-3.6 in a new PR and assign it to you.

In response to this:

/cherrypick redhat-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harishsurf
Copy link
Contributor

/assign @ricardomaraschini

@ricardomaraschini ricardomaraschini changed the title Remove namespace from build output Remove namespace from build output (PROJQUAY-2898) Feb 3, 2022
Copy link
Contributor

@ricardomaraschini ricardomaraschini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I have seen this is OK, trusting @harishsurf on this one. Approved.

@openshift-ci openshift-ci bot added the approved label Feb 3, 2022
Copy link
Contributor

@harishsurf harishsurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harishsurf, ricardomaraschini, ttaylor249

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-cherrypick-robot
Copy link
Collaborator

@harishsurf: new pull request created: #53

In response to this:

/cherrypick redhat-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ttaylor249 ttaylor249 deleted the build-mutate-issue39 branch February 3, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Issue with BuildConfig being mutated incorrectly
5 participants