Context Refactor #397
Merged
Context Refactor #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecmerdler
force-pushed
the
context-refactor
branch
3 times, most recently
from
f5e3253
to
c27c8f0
Compare
alecmerdler
force-pushed
the
context-refactor
branch
2 times, most recently
from
a2306d7
to
6e4b3ed
Compare
alecmerdler
force-pushed
the
context-refactor
branch
8 times, most recently
from
8cec3ce
to
34fcd3e
Compare
alecmerdler
force-pushed
the
context-refactor
branch
4 times, most recently
from
202383b
to
a237bc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were passing context such as the OpenShift cluster hostname, OBC connection info, and other required data using the
metadata.annotationson theQuayRegistry, then stripping out the annotations at the end of the reconcile loop. This was kind of a hack, but was done to maintain clean function interfaces without adding extra ad-hoc arguments.This pull request refactors the usage of annotations on the
QuayRegistryobject to instead use aQuayRegistryContext, and pass that as the first argument to functions that rely on additional information.Addresses https://issues.redhat.com/browse/PROJQUAY-1576