Remove Owner References from Grafana ConfigMap (PROJQUAY-1788) #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecmerdler
suggested changes
Mar 30, 2021
alecmerdler
changed the title
jonathankingfc
force-pushed
the
monitoring_fix
branch
from
545dc89
to
7639152
Compare
alecmerdler
reviewed
Mar 30, 2021
| @@ -357,6 +357,25 @@ func EnsureOwnerReference(quay *QuayRegistry, obj runtime.Object) (runtime.Objec | |||
| return obj, nil | |||
| } | |||
|
|
|||
| // RemoveOwnerReference removes the `ownerReference` of `QuayRegistry` on the given object. | |||
| func RemoveOwnerReference(quay *QuayRegistry, obj runtime.Object) (runtime.Object, error) { | |||
There was a problem hiding this comment.
Could you add a simple test for this?
alecmerdler
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/PROJQUAY-1788
Changelog:
ownerReferenceare injected on the grafana-dashboard config map. This prevents the cross-namespace owner references that caused resource to be garbage collected after creation.Docs:
Testing:
Details: