New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: github workflow to publish container images (PROJQUAY-2556) #530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks really good! left some comments. Let me know if you have questions
8584085
to
869582e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
b4aa563
to
b8f773c
Compare
I have changed a few things (and retested it all), please have another look! |
f298d41
to
1244687
Compare
* chore: github workflow to publish container images (PROJQUAY-2556) (#530) * feat: setup e2e nightly run (PROJQUAY-2556) (#535) * fix(workflow): use correct clair and builder-qemu tags (#553) * fix: use clair nightly build clair is in the process of removing their redhat-* branches, and asked us to use their nightly instead. also use correct tag for qemu builder image. * fix(build): use bundle image digest instead of tag (PROJQUAY-2556) (#557) and use env var to set it. increase e2e timeout too, as 3 minutes ins't always enough for the mirror to get up and running. * refactor(build-workflow): infer image tag from branch name (PROJQUAY-2612) (#556) This change ties the build workflow to the name of the branches it runs against. In a future where downstream releases are fully (or nearly) automated, we should probably tag the redhat-* branches for everything we want built, alpha, release candidates, etc. When this is done, this workflow should be updated to get triggered when new tags are created. * fix(build): add missed curly braces in expression (#559) * fix: pull correct image on build workflow (PROJQUAY-2556) (#560) * fix: use correct pull syntax on workflow (PROJQUAY-2556)
For now this targets branch
redhat-3.5
, but we can reuse it for any branch (as long as we update the image tags accordingly). The end goal is to use the builds produced by this workflow on a nightly job that will deploy Quay using this operator.One important thing to notice is that related projects (clair, quay-builder, etc) also need to publish an equivalent
3.5
image. I'll have PRs open and merged for these projects before merging this one.Example of a successful workflow (using my own registry instead of
projectquay
).