hack: setup and teardown scripts for e2e envs #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavianmissi
changed the title
dmage
previously approved these changes
Nov 25, 2021
dmage
reviewed
Nov 25, 2021
flavianmissi
force-pushed
the
run-e2e-locally
branch
from
2cd46e6
to
c218851
Compare
|
e2e tests have started failing after some point in this PR (https://github.com/flavianmissi/quay-operator/runs/4332403123?check_suite_focus=true). |
flavianmissi
force-pushed
the
run-e2e-locally
branch
from
c218851
to
033b040
Compare
|
Problem was that the line below, in endpoint="$(oc get quayregistry skynet -o jsonpath='{.status.registryEndpoint}')"After adding the namespace the new run is successful: https://github.com/flavianmissi/quay-operator/runs/4332862425?check_suite_focus=true |
flavianmissi
force-pushed
the
run-e2e-locally
branch
from
033b040
to
e0b1553
Compare
flavianmissi
added a commit
to flavianmissi/quay-operator
that referenced
this pull request
Dec 6, 2021
* hack/deploy.sh: deploys the operator and a quayregistry instance, and ensures everything is up and running. will exit 1 otherwise * hack/teardown.sh: removes everything created by deploy.sh * hack/storage.sh: installs the openshift container storage from the red hat catalog and creates a noobaa instance Fixes PROJQUAY-2823
flavianmissi
added a commit
that referenced
this pull request
Dec 6, 2021
* hack/deploy.sh: deploys the operator and a quayregistry instance, and ensures everything is up and running. will exit 1 otherwise * hack/teardown.sh: removes everything created by deploy.sh * hack/storage.sh: installs the openshift container storage from the red hat catalog and creates a noobaa instance Fixes PROJQUAY-2823
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes 3 shell scripts:
hack/deploy.sh: deploys the operator and a quayregistry instance, and ensures everything is up and running. will exit 1 otherwisehack/teardown.sh: removes everything created bydeploy.shhack/storage.sh: installs the openshift container storage from the red hat catalog and creates a noobaa instancenote that some functions, like
info, are duplicated in different files. since they are trivial, I didn't see much of a problem with it, at least for now.Fixes PROJQUAY-2823