sso: Add test for RHSSO OAuth service (PROJQUAY-2056)

- Add test for RHSSOOAuthService class
quay · May 11, 2022 · acddb61 · acddb61
1 parent 587cceb
commit acddb61
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/oauth/loginmanager.py b/oauth/loginmanager.py
@@ -28,10 +28,10 @@ def __init__(self, config, client=None):
                     if custom_service.login_enabled(config):
                         self.services.append(custom_service)
                 else:
-                    prefix = key.rstrip("_LOGIN_CONFIG").lower()
+                    prefix = key[: -len("_LOGIN_CONFIG")].lower()
                     if prefix in PREFIX_BLACKLIST:
                         raise Exception("Cannot use reserved config name %s" % key)
-                    if prefix == "rhsso":
+                    if prefix == "rhss":
                         self.services.append(RHSSOOAuthService(config, key, client=client))
                     else:
                         self.services.append(OIDCLoginService(config, key, client=client))

diff --git a/oauth/services/rhsso.py b/oauth/services/rhsso.py
@@ -32,7 +32,9 @@ def exchange_code_for_login(self, app_config, http_client, code, redirect_suffix
                 )
                 logger.debug("Got result from export compliance service: " + result.json())
                 if result.status_code != 200:
-                    raise OAuthLoginException(str(result.json()["errors"]))
+                    raise OAuthLoginException(str(result.json()))
+                if result.json()["result"] != "OK":
+                    raise OAuthLoginException(str(result.json()["description"]))
             except Exception as e:
                 raise OAuthLoginException(str(e))
 

diff --git a/oauth/test/test_loginmanager.py b/oauth/test/test_loginmanager.py
@@ -2,6 +2,7 @@
 from oauth.services.github import GithubOAuthService
 from oauth.services.google import GoogleOAuthService
 from oauth.oidc import OIDCLoginService
+from oauth.services.rhsso import RHSSOOAuthService
 
 
 def test_login_manager_github():
@@ -66,3 +67,11 @@ def test_multiple_oidc():
     assert len(loginmanager.services) == 2
     assert isinstance(loginmanager.services[0], OIDCLoginService)
     assert isinstance(loginmanager.services[1], OIDCLoginService)
+
+
+def test_rhsso():
+    config = {"RHSSO_LOGIN_CONFIG": {}}
+
+    loginmanager = OAuthLoginManager(config)
+    assert len(loginmanager.services) == 1
+    assert isinstance(loginmanager.services[0], RHSSOOAuthService)