proxy: raise UpstreamRegistryError if we can't request upstream #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requests will either throw a RequestException or a ConnectionError if it fails to request the given url for whatever reason. callers are only expected to treat UpstreamRegistryError, so we throw it instead of the requests related exceptions, adding the original message to the new exception.
Sunandadadi
approved these changes
Mar 31, 2022
Sunandadadi
pushed a commit
to Sunandadadi/quay
that referenced
this pull request
Mar 31, 2022
…#1220) requests will either throw a RequestException or a ConnectionError if it fails to request the given url for whatever reason. callers are only expected to treat UpstreamRegistryError, so we throw it instead of the requests related exceptions, adding the original message to the new exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requests will either throw a RequestException or a ConnectionError if it
fails to request the given url for whatever reason.
callers are only expected to treat UpstreamRegistryError, so we throw it
instead of the requests related exceptions, adding the original message
to the new exception.