Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defaults: Update defaults in config and schema (PROJQUAY-2425) #923

Merged
merged 1 commit into from
Oct 12, 2021
Merged

defaults: Update defaults in config and schema (PROJQUAY-2425) #923

merged 1 commit into from
Oct 12, 2021

Conversation

jonathankingfc
Copy link
Contributor

  • Add defaults to config tool for FEATURE_USER_INITIALIZE, FEATURE_EXTENDED_REPOSITORY_NAMES, and CREATE_REPOSITORY_ON_PUSH_PUBLIC

@app-sre-bot
Copy link
Collaborator

Can one of the admins verify this patch?

Sunandadadi
Sunandadadi previously approved these changes Oct 11, 2021
View reviewed changes
@jonathankingfc jonathankingfc force-pushed the PROJQUAY-2425 branch 3 times, most recently from 0dba9e2 to d44c410 Compare October 12, 2021 18:55
harishsurf
harishsurf previously approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@harishsurf harishsurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ok-to-merge once CI passes

kleesc
kleesc requested changes Oct 12, 2021
View reviewed changes
test/registry/registry_tests.py Outdated Show resolved Hide resolved
kleesc
kleesc requested changes Oct 12, 2021
View reviewed changes
test/registry/registry_tests.py Outdated Show resolved Hide resolved
kleesc
kleesc requested changes Oct 12, 2021
View reviewed changes
test/test_api_usage.py Outdated Show resolved Hide resolved
@jonathankingfc jonathankingfc merged commit a29f3e0 into master Oct 12, 2021
jonathankingfc added a commit that referenced this pull request Oct 12, 2021
@jonathankingfc
defaults: Update defaults in config and schema (PROJQUAY-2425) (#923)
e4aab60 
- Update defaults in config.pu
jonathankingfc added a commit that referenced this pull request Oct 12, 2021
@jonathankingfc
defaults: Update defaults in config and schema (PROJQUAY-2425) (#923) (…
26a0676 
…#925)

- Update defaults in config.pu
@flavianmissi flavianmissi deleted the PROJQUAY-2425 branch April 8, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kleesc kleesc kleesc approved these changes

@Sunandadadi Sunandadadi Sunandadadi left review comments

@harishsurf harishsurf harishsurf left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jonathankingfc @app-sre-bot @kleesc @Sunandadadi @harishsurf