New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: Update config-tool to v0.1.11 (PROJQUAY-3318) #1195
Conversation
jonathankingfc
commented
Mar 22, 2022
- Update config-tool version from v0.1.10 to v0.1.11
- Update config-tool version from v0.1.10 to v0.1.11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://issues.redhat.com/browse/PROJQUAY-3318
@HammerMeetNail this one addresses two blocker bugs. As @jonathankingfc ended closing the Jira cards can you prioritize the review of this one ? I think we also need to update the "midstream", can you confirm ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I don't think we need to update the midstream for config-tool. I don't see anything that jumps out at me in the midstream Dockerfile for config-tool. @flavianmissi @harishsurf Can either of you confirm? |
AFAIK as long as the config-tool commit makes it into the equivalent redhat branch the commit will be included in the next downstream build. |
/cherrypick redhat-3.7 |
@jonathankingfc: new pull request could not be created: failed to create pull request against quay/quay#redhat-3.7 from head openshift-cherrypick-robot:cherry-pick-1195-to-redhat-3.7: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between quay:redhat-3.7 and openshift-cherrypick-robot:cherry-pick-1195-to-redhat-3.7"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@jonathankingfc: new pull request could not be created: failed to create pull request against quay/quay#redhat-3.7 from head openshift-cherrypick-robot:cherry-pick-1195-to-redhat-3.7: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between quay:redhat-3.7 and openshift-cherrypick-robot:cherry-pick-1195-to-redhat-3.7"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |