Dockerfile: use nodejs ubi8 image to build frontends #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that we're using ubi8/node-10, which is deprecated - but this is the version previously installed (before the nodejs package disappeared on us).
flavianmissi
commented
Jun 2, 2022
| FROM registry.access.redhat.com/ubi8/nodejs-10 AS build-static | ||
| WORKDIR /opt/app-root/src | ||
| COPY --chown=1001:0 static/ ./static/ | ||
| COPY --chown=1001:0 *.json *.js ./ |
There was a problem hiding this comment.
see https://catalog.redhat.com/software/containers/ubi8/nodejs-10/5c839aa3d70cc51dd4c425d9?container-tabs=dockerfile for background on ownership change
kleesc
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add nginx module before installing it, without this dnf won't find it.
Note that we're using ubi8/node-10, which is deprecated - but this is
the version previously installed (before the nodejs package disappeared
on us).