Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init: ensure a newline is present before appending certs (PROJQUAY-3881) #1356

Merged
merged 1 commit into from Jun 2, 2022

Conversation

kleesc
Copy link
Member

@kleesc kleesc commented Jun 2, 2022

Make sure the script still works when mounting certs as a read-only fs.

Make sure the script still works when mounting certs as a read-only fs.
Copy link
Contributor

@bcaton85 bcaton85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kleesc kleesc merged commit 8786ef2 into quay:master Jun 2, 2022
@kleesc kleesc deleted the check-newline-certs-install-readonly branch June 2, 2022 20:54
@HammerMeetNail
Copy link
Contributor

/cherry-pick redhat-3.7

@openshift-cherrypick-robot

@HammerMeetNail: new pull request created: #1357

In response to this:

/cherry-pick redhat-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@HammerMeetNail
Copy link
Contributor

/cherry-pick redhat-3.6

@openshift-cherrypick-robot

@HammerMeetNail: new pull request created: #1488

In response to this:

/cherry-pick redhat-3.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants