New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: basic support for cosign in the UI (PROJQUAY-3965) #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmage
reviewed
Jun 14, 2022
Co-authored-by: Oleg Bulatov <oleg@bulatov.me>
Sunandadadi
reviewed
Jun 14, 2022
Sunandadadi
reviewed
Jun 15, 2022
dmage
reviewed
Jun 15, 2022
dmage
approved these changes
Jun 16, 2022
/cherry-pick redhat-3.7 |
@HammerMeetNail: new pull request created: #1414 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic UI support for handling cosign-style signature artifacts separately from regular tags. Filters cosign signature tags from the tag view by default but allows them to be revealed. Visually annotates signed images and provides additional links and information about to the signature artifact in the expanded manifest view. Also allows to select signed vs. unsigned tags and cosign signature artifacts from the tag dropdown filter.