oci: Disable active_repo_tags_cache for tests (PROJQUAY-3872) #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmage
force-pushed
the
disable-tag-cache
branch
from
c86659f
to
35513e0
Compare
dmage
changed the title
dmage
changed the title
dmage
force-pushed
the
disable-tag-cache
branch
10 times, most recently
from
f760697
to
eefd0b3
Compare
dmage
force-pushed
the
disable-tag-cache
branch
from
eefd0b3
to
35a32ab
Compare
dmage
changed the title
bcaton85
reviewed
Aug 26, 2022
| @@ -50,7 +50,7 @@ def get(self, key, default_value=None): | |||
| # Otherwise the key has expired or was not found. Rebuild the cache and check it again. | |||
| items = self._rebuild() | |||
| found_item = items.get(key) | |||
| if found_item is None: | |||
| if found_item is None or found_item.expired: | |||
There was a problem hiding this comment.
Was this required for tests to pass?
There was a problem hiding this comment.
yes, otherwise the in-memory cache can incorrectly return an expired item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OCI Content Discovery tests requires Quay to immediately reflect tag changes in tag lists when a tag is created/deleted, so to make tests green we should disable active_repo_tags_cache.