arch: add ppc64le support to quay (PROJQUAY-4595) #1535
Conversation
|
Can one of the admins verify this patch? |
|
@HammerMeetNail can you please review this? |
|
@snehakpersistent We're having some discussions on adding ppc64le support. Gonna hold this for a moment while we wait for consensus. Should have an answer in the coming days. |
|
@HammerMeetNail any update on this? |
|
Not yet, I'll be talking more with our product owner this week about this. I think we may also have an email thread floating around that could be revived? |
|
@HammerMeetNail I have replied in the email thread that was started on Quay support for Power |
|
@HammerMeetNail any update on this? |
requirements.txt
Outdated
| greenlet==1.1.2 | ||
| grpcio==1.46.3 | ||
| grpcio |
There was a problem hiding this comment.
we need pinned versions here - did this cause any issues?
There was a problem hiding this comment.
@flavianmissi @HammerMeetNail our intention was to use latest versions. We are currently using pre-built wheel files for ppc64le arch published under official GitHub repositories maintained by IBM. Since we have pre-built binaries for grpcio v1.46.3 and gevent 21.8.0 we can continue using same versions. I have updated the code accordingly. Can you please re-review?
|
@snehakpersistent We talked more about this today and should be able to merge upstream. Can you address @flavianmissi feedback on pinning versions? We'll need to see what we can do to find ppc64le runners so builds don't take an excessive amount of time. |
|
@flavianmissi @HammerMeetNail looks like few linting jobs failed. Any changes are required from my end? |
There was a problem hiding this comment.
that should be okay @snehakpersistent, those checks are optional.
@HammerMeetNail are we a go for merging this? LGTM.
HammerMeetNail
changed the title
|
/cherry-pick redhat-3.8 |
|
@HammerMeetNail: new pull request created: #1558 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@flavianmissi Thanks for the review, merged. |
|
@HammerMeetNail @flavianmissi thanks a lot! Any idea about when the official quay image for ppc64le will be GA? |
|
I think the upstream I've opened a PR to pull this into our 3.8 branch, so when we release that upstream, it should also build a ppc64le image. Release for 3.8 is currently scheduled for the last week of October. Downstream is a different story. We'll need to loop in our QE team for additional testing. If you're interested in the downstream image, let's chat more via our email chain. |
|
Looks like the upstream image is live, |
|
@HammerMeetNail that's awesome! |
Add ppc64le support to quay image