PROJQUAY-38 - fix test imports #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
There was a problem hiding this comment.
@thomasmckay
Can you share what error(s) are popping up due to the imports? I am curious if we need to run 2to3 again after having rebased on master which is still using Python 2.7.
kurtismullins
force-pushed
the
python3
branch
from
d539928
to
8ea8df6
Compare
|
@thomasmckay It looks like there is a conflict with |
thomasmckay
force-pushed
the
test-imports
branch
from
17b7e30
to
2e024df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/PROJQUAY-68
Fix imports for test files