ui: use route location instead of window.location (PROJQUAY-5392) #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
window.location causes issues when running in beta or preview on console
Sunandadadi
reviewed
Apr 28, 2023
| @@ -69,6 +69,9 @@ export default function RepositoriesList(props: RepositoriesListProps) { | |||
| const [makePublicModalOpen, setmakePublicModal] = useState(false); | |||
| const [makePrivateModalOpen, setmakePrivateModal] = useState(false); | |||
| const [err, setErr] = useState<string[]>(); | |||
| const location = useLocation(); | |||
|
|
|||
| console.log('current route location', location.pathname); | |||
There was a problem hiding this comment.
Can you remove the console.log
Sunandadadi
reviewed
Apr 28, 2023
| @@ -414,3 +429,7 @@ interface RepoListTableItem { | |||
| size: number; | |||
| last_modified: number; | |||
| } | |||
|
|
|||
| interface RepositoriesListProps { | |||
| organizationName: string; | |||
There was a problem hiding this comment.
Is there a reason for adding the props here? I don't see the organizationName getting used in the PR.
There was a problem hiding this comment.
I see RepositoriesListProps used in src/routes/RepositoriesList/RepositoriesList.tsx:65 but it's not defined so I'm defining it
Sunandadadi
reviewed
Apr 28, 2023
| @@ -20,6 +20,7 @@ function getTabIndex(tab: string) { | |||
| export default function TagTabs(props: TagTabsProps) { | |||
| const [activeTabKey, setActiveTabKey] = useState<TabIndex>(TabIndex.Details); | |||
| const navigate = useNavigate(); | |||
| const location = useLocation(); | |||
There was a problem hiding this comment.
location here doesn't seem to getting used in the PR.
There was a problem hiding this comment.
it's used in src/routes/TagDetails/TagDetailsTabs.tsx:35 but not defined in the context which causes issues
dmesser
pushed a commit
to dmesser/quay
that referenced
this pull request
May 4, 2023
…ay#1844) * ui: use route location instead of window.location (PROJQUAY-5392) window.location causes issues when running in beta or preview on console * remove console.log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
window.location causes issues when running in beta or preview on console