fix: Accept schema 2 images as OCI index children (PROJQUAY-4826) #1959
Conversation
|
Is this according to standard? |
dmage
changed the title
|
@ibazulic apparently no, so the PR is updated; now it's about supporting schema 2 images in OCI image indexes. |
|
@dmage Discussion here: opencontainers/image-spec#1150 |
|
Apparently, it's our choice whether to support it or not. |
| @@ -262,6 +264,8 @@ def manifests(self, content_retriever): | |||
| """ | |||
| manifests = self._parsed[INDEX_MANIFESTS_KEY] | |||
| supported_types = {} | |||
| supported_types[DOCKER_SCHEMA2_MANIFEST_CONTENT_TYPE] = DockerSchema2Manifest | |||
| supported_types[DOCKER_SCHEMA2_MANIFESTLIST_CONTENT_TYPE] = DockerSchema2ManifestList | |||
There was a problem hiding this comment.
There are a lot of assumptions in the code when dealing with parent tags of manifest lists. This might break some of those assumptions. e.g. When expiring a tag past the time machine, we expire the parent tag. In this scenario it's actually the parent tag of the parent tag that would need to be expired. Garbage collection also just checks the parent tag. We would probably want some additional testing around this to what exactly happens when you push nested manifest lists.
There was a problem hiding this comment.
I added this line because there is already one for OCI index:
supported_types[OCI_IMAGE_INDEX_CONTENT_TYPE] = OCIIndex
This change fixes PROJQUAY-4826.