-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Robot Accounts tab fixes (PROJQUAY-5914) #2097
Conversation
@Sunandadadi is this PR ready for review or is it WIP (the 4th item is WIP in the description)? |
@dmage it is WIP, updated the title of the PR. |
1bb63cb
to
a119b2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think there should be success/failure alerts when the settings change but that can be done in a follow up PR.
web/src/components/modals/robotAccountWizard/AddToRepository.tsx
Outdated
Show resolved
Hide resolved
{ | ||
onSuccess: () => { | ||
onSuccess: async (result) => { | ||
await Promise.allSettled([updateRobotData(result)]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if these requests fail? Is that caught and handled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, pushed handing for onError. Verified that OnError
is defined in all the places useRobotAccounts
hook is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cherry-pick redhat-3.9 |
/cherrypick redhat-3.9 |
@Sunandadadi: new pull request created: #2135 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Sunandadadi: new pull request could not be created: failed to create pull request against quay/quay#redhat-3.9 from head openshift-cherrypick-robot:cherry-pick-2097-to-redhat-3.9: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-2097-to-redhat-3.9."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick redhat-3.9 |
@Sunandadadi: #2097 failed to apply on top of branch "redhat-3.9":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR fixes: