storage: adding maximum_chunk_size_gb storage option (PROJQUAY-2679) #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2186 +/- ##
==========================================
- Coverage 70.23% 70.23% -0.01%
==========================================
Files 432 432
Lines 39305 39304 -1
Branches 5088 5088
==========================================
- Hits 27606 27605 -1
- Misses 10112 10114 +2
+ Partials 1587 1585 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
syed
previously approved these changes
Aug 28, 2023
bcaton85
changed the title
bcaton85
force-pushed
the
PROJQUAY-2679
branch
from
bc2a543
to
9215251
Compare
bcaton85
changed the title
openshift-ci
bot
added
do-not-merge/work-in-progress
and removed
do-not-merge/work-in-progress
labels
syed
approved these changes
Aug 29, 2023
|
Yup that's right, i'll bring in @stevsmit |
kleesc
approved these changes
Aug 30, 2023
|
/cherry-pick redhat-3.9 |
|
@bcaton85: new pull request created: #2191 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sunandadadi
pushed a commit
to Sunandadadi/quay
that referenced
this pull request
Aug 30, 2023
…uay#2186) Adds the `maximum_chunk_size_gb` option to s3 storage to reduce chunk size and increase performance. Also removes redundant storage copy call.
raja-0940
pushed a commit
to raja-0940/quay
that referenced
this pull request
Sep 25, 2023
…uay#2186) Adds the `maximum_chunk_size_gb` option to s3 storage to reduce chunk size and increase performance. Also removes redundant storage copy call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users are currently using the
S3storageoption to use the IBM storage solution. The final copy of an image push from theuploadsto thesha256storage directory currently fails for large image layers (10gb). This is due to the 10gb layer being chunked into 5gb ranges that causes delays in the IBM copy operation. This PR adds performance by removing an unnecessary copy and adds themaximum_chunk_size_gboption to reduce the size of the copy.