Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

georeplication: Enqueue blobs for replication on manifest list pushes (PROJQUAY-5256) #2212

Conversation

ibazulic
Copy link
Member

@ibazulic ibazulic commented Sep 6, 2023

Previously, blob replication was only queued when normal manifests were pushed to the registry. This created problems with manifest lists who contain child manifests whose blobs were never queued. The end result was a huge discrepancy of storage usage between different defined storage engines.

With this fix, blobs will always be enqueued for replication regardless of the image type.

… (PROJQUAY-5256)

Previously, blob replication was only queued when normal manifests were pushed to the registry. This created problems with manifest lists who contain child manifests whose blobs were never queued. The end result was a huge discrepancy of storage usage between different defined storage engines.
With this fix, blobs will always be enqueued for replication regardless of the image type.
@ibazulic ibazulic requested a review from syed September 6, 2023 18:17
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage is 10.00% of modified lines.

Files Changed Coverage
endpoints/v2/manifest.py 10.00%

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@bcaton85 bcaton85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibazulic ibazulic merged commit abfde5b into quay:master Sep 12, 2023
14 of 15 checks passed
@dmage
Copy link
Member

dmage commented Sep 12, 2023

/cherrypick redhat-3.9

@openshift-cherrypick-robot

@dmage: new pull request created: #2232

In response to this:

/cherrypick redhat-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants