ui: adding alerts for robot account actions (PROJQUAY-5946) #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sunandadadi
changed the title
Codecov ReportAll modified lines are covered by tests ✅ see 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
Sunandadadi
changed the title
Sunandadadi
force-pushed
the
PROJQUAY-5946
branch
from
ac35785
to
a155057
Compare
Sunandadadi
changed the title
bcaton85
reviewed
Oct 3, 2023
bcaton85
reviewed
Oct 3, 2023
...es/OrganizationsList/Organization/Tabs/DefaultPermissions/createTeamWizard/AddTeamMember.tsx
Outdated
Show resolved
Hide resolved
bcaton85
reviewed
Oct 3, 2023
web/src/hooks/useRobotAccounts.ts
Outdated
| const queryClient = useQueryClient(); | ||
|
|
||
| const createRobotAccntMutator = useMutation( | ||
| const updateRobotData = async (result) => { |
There was a problem hiding this comment.
These calls aren't handled with error handling. A success will still be reported to the user if the robot was created successfully even if these all fail.
There was a problem hiding this comment.
Yes, I think this was done to make sure a robotAcct is created before adding repos/teams/etc to the robot acct.
Sunandadadi
force-pushed
the
PROJQUAY-5946
branch
from
26ede52
to
91800cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.