secscan: add support for new enrichment type (PROJQUAY-5981) #2235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crozzy
force-pushed
the
support-for-rhcc-enrichments
branch
from
a3c153b
to
e0a6a52
Compare
Codecov ReportAttention:
... and 34 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
crozzy
force-pushed
the
support-for-rhcc-enrichments
branch
from
e0a6a52
to
423b89f
Compare
crozzy
force-pushed
the
support-for-rhcc-enrichments
branch
3 times, most recently
from
ce6a229
to
835dcd9
Compare
This change adds the ability for Quay to reason with the rhcc-enrichment that Clair will return in the vulnerability reports. This information is meant to allow users or applications to determine which packages come from rhcc layers. Signed-off-by: crozzy <joseph.crosland@gmail.com>
crozzy
force-pushed
the
support-for-rhcc-enrichments
branch
from
835dcd9
to
10a3402
Compare
|
@hdonnay at the moment this ignores vulnerabilities that come from layers with an rhcc package except vulnerabilities directly related to the rhcc package. Do you think that is the desired behaviour? I'm not sure if we also want to include other vulnerabilities as well. |
|
I think that's right, but we should engage with stakeholders and drive a consensus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the ability for Quay to reason with the rhcc-enrichment that Clair will return in the vulnerability reports. This information is meant to allow users or applications to determine which packages come from rhcc layers.