ui: Upgrade to PatternFly v5 (PROJQUAY-6085) #2281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
dmage
changed the title
jpuzz0
force-pushed
the
pf-v5-upgrade
branch
2 times, most recently
from
e8687ef
to
f39bbd0
Compare
Codecov ReportAll modified lines are covered by tests ✅ see 3 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
dmage
previously approved these changes
Oct 6, 2023
dmage
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue #: https://issues.redhat.com/browse/PROJQUAY-6085
Summary
Notes
There is a known issue with the latest DatePicker which was identified while updating this app, and reported here. The workaround implemented as a part of this PR is to default the date selection to 1 day after today. This allows for appropriate month navigation within the CalendarMonth component.
Some deprecated components are still in use here (imported via
@patternfly/react-core/deprecated). These are intentionally still exposed to provide teams with more time to address functional and syntactical changes required. This will be the next step in the process of migration to PFv5.Also, there are a handful of existing eslint & prettier issues amongst many of the files updated in this change. This is something that can be addressed in separate issues.