ui: Add create new team button (PROJQUAY-5685) #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅ see 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
harishsurf
force-pushed
the
projquay-5685
branch
3 times, most recently
from
b67c4b3
to
0511c61
Compare
bcaton85
reviewed
Oct 16, 2023
| </Conditional> | ||
| <Conditional if={props.isTeamWizardOpen}> | ||
| {props.createTeamWizard} | ||
| </Conditional> |
There was a problem hiding this comment.
Couldn't these modals be rendered in the parent component? That way you don't need the state props for whether they're open, you only pass the handleModalToggle. You can then also remove the conditional renders from all the *ViewList.tsx components.
There was a problem hiding this comment.
moved it to parent component. Code looks much cleaner now with lesser props being passed down. Thanks!
...src/routes/OrganizationsList/Organization/Tabs/TeamsAndMembership/TeamsAndMembershipList.tsx
Outdated
Show resolved
Hide resolved
harishsurf
force-pushed
the
projquay-5685
branch
from
0511c61
to
be64e9c
Compare
Signed-off-by: harishsurf <hgovinda@redhat.com>
harishsurf
force-pushed
the
projquay-5685
branch
from
be64e9c
to
71172db
Compare
harishsurf
force-pushed
the
projquay-5685
branch
from
71172db
to
af53238
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds create new team button under teams and membership tab: