ui: Fix styling conflict with RedHatInsights (PROJQUAY-6085) #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpuzz0
changed the title
jpuzz0
changed the title
Codecov ReportAll modified lines are covered by tests ✅ see 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using an older version of https://github.com/RedHatInsights/frontend-components, some styles in the patternfly v5 wizard were not being respected. Updating that package (and adding appropriate resolutions since it has a dependency on react v18), moving the import of patternfly css, and adding appropriate resolutions in the package.json seems to have remedied the styling conflicts.
Also, there was 1 page section that needed to remove padding still, which was leftover rework from the removal of deprecated patternfly components.
Screen.Recording.2023-10-18.at.11.15.03.AM.mov