api: graceful error handling for robot acct already exists (PROJQUAY-6261) #2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 4 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
bcaton85
reviewed
Oct 26, 2023
endpoints/api/robot.py
Outdated
| @@ -121,6 +122,12 @@ def put(self, robot_shortname): | |||
| """ | |||
| parent = get_authenticated_user() | |||
| create_data = request.get_json(silent=True) or {} | |||
|
|
|||
| if model.robot_account_exists(robot_shortname, parent, user=True) is not None: | |||
There was a problem hiding this comment.
Is it better to catch the duplicate name error returned by create_user_robot and re-raise the request_error? That way we don't add any additional API requests. Same for the org endpoint.
There was a problem hiding this comment.
Yes, good point.
Sunandadadi
force-pushed
the
PROJQUAY-6261
branch
from
9c9b338
to
eaff3df
Compare
Sunandadadi
force-pushed
the
PROJQUAY-6261
branch
from
eaff3df
to
83f65f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes care of graceful error handling instead of raising an exception for create robot account endpoint. Added the same error to propagate on the new UI too.