ui: display manifest list size range (PROJQUAY-6393) #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dmesser <dmesser@redhat.com>
Signed-off-by: dmesser <dmesser@redhat.com>
Signed-off-by: dmesser <dmesser@redhat.com>
dmesser
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2469 +/- ##
==========================================
+ Coverage 70.50% 70.55% +0.04%
==========================================
Files 434 434
Lines 39817 39826 +9
Branches 5164 5164
==========================================
+ Hits 28074 28099 +25
+ Misses 10121 10104 -17
- Partials 1622 1623 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I like this |
bcaton85
reviewed
Nov 15, 2023
Signed-off-by: dmesser <dmesser@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of displaying
N/AorUnknownin the size column, a tag pointing to a manifest list should display size information. Since clients by default select only a specific child manifest of a manifest list, I opted here for a display of the size of the smallest and the largest child manifest.Screen.Recording.2023-11-09.at.23.00.47.mov