Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[redhat-3.10] ui: breadcrumbs on new ui (PROJQUAY-5452) #2490

Merged
merged 2 commits into from Dec 5, 2023

Conversation

Sunandadadi
Copy link
Contributor

@Sunandadadi Sunandadadi commented Nov 15, 2023

This is a manual cherry-pick of #1893

Sunandadadi and others added 2 commits November 15, 2023 12:57
* UI: Breadcrumbs fix (PROJQUAY-5452)

* minor fixes

* using a generalized function to fetch the next breadcrumb item

* remove building breadcrumbs from browser histroy

* add tests

* fixing eslint

* fetching element from test-id instead of patternfly class
@Sunandadadi Sunandadadi changed the title Cherry pick 1893 to redhat 3.10 [redhat-3.10] ui: breadcrumbs on new ui (PROJQUAY-5452) Nov 15, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ecfd47) 70.47% compared to head (d283c70) 70.47%.

Additional details and impacted files
@@               Coverage Diff               @@
##           redhat-3.10    #2490      +/-   ##
===============================================
- Coverage        70.47%   70.47%   -0.01%     
===============================================
  Files              434      434              
  Lines            39792    39792              
  Branches          5163     5163              
===============================================
- Hits             28045    28044       -1     
  Misses           10126    10126              
- Partials          1621     1622       +1     
Flag Coverage Δ
unit 70.47% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmage dmage merged commit fea7c2c into quay:redhat-3.10 Dec 5, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants