Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: add breadcrumbs for teams page (PROJQUAY-6442) #2504

Merged
merged 3 commits into from Nov 28, 2023

Conversation

Sunandadadi
Copy link
Contributor

Adds breadcrumbs for teams page + tests.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (161a471) 70.55% compared to head (1905035) 70.55%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2504   +/-   ##
=======================================
  Coverage   70.55%   70.55%           
=======================================
  Files         434      434           
  Lines       39826    39826           
  Branches     5164     5164           
=======================================
  Hits        28099    28099           
- Misses      10102    10104    +2     
+ Partials     1625     1623    -2     
Flag Coverage Δ
unit 70.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@harishsurf harishsurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Sunandadadi Sunandadadi merged commit a9eaa38 into quay:master Nov 28, 2023
15 checks passed
@Sunandadadi Sunandadadi deleted the PROJQUAY-6442 branch November 29, 2023 14:06
@Sunandadadi
Copy link
Contributor Author

/cherry-pick redhat-3.10

@openshift-cherrypick-robot

@Sunandadadi: #2504 failed to apply on top of branch "redhat-3.10":

Applying: ui: add breadcrumbs for teams page (PROJQUAY-6442)
Using index info to reconstruct a base tree...
A	web/cypress/e2e/breadcrumbs.cy.ts
M	web/src/components/breadcrumb/Breadcrumb.tsx
M	web/src/routes/NavigationPath.tsx
Falling back to patching base and 3-way merge...
Auto-merging web/src/routes/NavigationPath.tsx
CONFLICT (content): Merge conflict in web/src/routes/NavigationPath.tsx
Auto-merging web/src/components/breadcrumb/Breadcrumb.tsx
CONFLICT (content): Merge conflict in web/src/components/breadcrumb/Breadcrumb.tsx
CONFLICT (modify/delete): web/cypress/e2e/breadcrumbs.cy.ts deleted in HEAD and modified in ui: add breadcrumbs for teams page (PROJQUAY-6442). Version ui: add breadcrumbs for teams page (PROJQUAY-6442) of web/cypress/e2e/breadcrumbs.cy.ts left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 ui: add breadcrumbs for teams page (PROJQUAY-6442)
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick redhat-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants