Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache: adding caching on look_up repository (PROJQUAY-6472) #2521

Merged
merged 4 commits into from
Jan 16, 2024

Conversation

Sunandadadi
Copy link
Contributor

@Sunandadadi Sunandadadi commented Dec 1, 2023

This PR caches the response of model.repository.get_repository as a json object instead of picking as done in #2515.

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2410c7a) 70.56% compared to head (99a94cf) 70.68%.
Report is 25 commits behind head on master.

Files Patch % Lines
data/cache/cache_key.py 75.00% 1 Missing and 1 partial ⚠️
endpoints/v2/manifest.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2521      +/-   ##
==========================================
+ Coverage   70.56%   70.68%   +0.12%     
==========================================
  Files         434      434              
  Lines       39826    39940     +114     
  Branches     5164     5183      +19     
==========================================
+ Hits        28102    28232     +130     
+ Misses      10101    10080      -21     
- Partials     1623     1628       +5     
Flag Coverage Δ
unit 70.68% <88.88%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@syed syed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sunandadadi Sunandadadi merged commit a773772 into quay:master Jan 16, 2024
15 checks passed
@Sunandadadi Sunandadadi deleted the PROJQUAY-6472-fix branch January 16, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants