cache: add caching for manifest requests (PROJQUAY-6482) #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleesc
force-pushed
the
cache-manifest-requests
branch
from
0316c79
to
3b45db5
Compare
kleesc
changed the title
kleesc
force-pushed
the
cache-manifest-requests
branch
6 times, most recently
from
1875fab
to
2028924
Compare
kleesc
force-pushed
the
cache-manifest-requests
branch
4 times, most recently
from
c6bc215
to
e449f8b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2522 +/- ##
=======================================
Coverage 70.79% 70.79%
=======================================
Files 436 436
Lines 40526 40573 +47
Branches 5283 5286 +3
=======================================
+ Hits 28690 28725 +35
- Misses 10159 10172 +13
+ Partials 1677 1676 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kleesc
force-pushed
the
cache-manifest-requests
branch
7 times, most recently
from
baeb51a
to
374550e
Compare
kleesc
force-pushed
the
cache-manifest-requests
branch
from
374550e
to
24eb217
Compare
Sunandadadi
reviewed
Mar 4, 2024
| "repository" | ||
| ].asdict() | ||
| manifest_dict["inputs"]["legacy_image_handler"] = None # TODO(kleesc): Remove | ||
| manifest_dict["inputs"]["legacy_id_handler"] = None # TODO(kleesc): Remove |
There was a problem hiding this comment.
did you miss removing the above 2 lines?
There was a problem hiding this comment.
These should be removed once #2555 is merged. For now, they're still expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.