Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marketplace: add exception handling for reconciler (PROJQUAY-233) #2560

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

Marcusk19
Copy link
Contributor

Add exception handling for stripe api if it receives a bad request for a user's stripe id.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (4f0c8db) 70.58% compared to head (edc08b6) 70.59%.
Report is 2 commits behind head on master.

Files Patch % Lines
workers/reconciliationworker.py 37.50% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2560   +/-   ##
=======================================
  Coverage   70.58%   70.59%           
=======================================
  Files         434      434           
  Lines       39855    39856    +1     
  Branches     5168     5166    -2     
=======================================
+ Hits        28131    28135    +4     
- Misses      10100    10104    +4     
+ Partials     1624     1617    -7     
Flag Coverage Δ
unit 70.59% <52.38%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kleesc
kleesc previously approved these changes Dec 15, 2023
@Marcusk19 Marcusk19 merged commit 79723f1 into quay:master Dec 15, 2023
14 of 15 checks passed
@Marcusk19 Marcusk19 deleted the reconciler-stripe branch December 15, 2023 17:32
Sunandadadi pushed a commit to Sunandadadi/quay that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants