Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configtool: Adding validation for IBM Cloud Storage (PROJQUAY-6549) #2568

Merged
merged 1 commit into from Dec 20, 2023

Conversation

bcaton85
Copy link
Contributor

Adding config validation for the IBMCloudStorage option.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f0c8db) 70.58% compared to head (59d8fbe) 70.59%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2568   +/-   ##
=======================================
  Coverage   70.58%   70.59%           
=======================================
  Files         434      434           
  Lines       39855    39856    +1     
  Branches     5168     5166    -2     
=======================================
+ Hits        28131    28135    +4     
- Misses      10100    10104    +4     
+ Partials     1624     1617    -7     
Flag Coverage Δ
unit 70.59% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jonathankingfc jonathankingfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcaton85 bcaton85 merged commit 94735bc into quay:master Dec 20, 2023
19 checks passed
@bcaton85
Copy link
Contributor Author

bcaton85 commented Jan 3, 2024

/cherry-pick redhat-3.10

@openshift-cherrypick-robot

@bcaton85: new pull request created: #2581

In response to this:

/cherry-pick redhat-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sunandadadi pushed a commit to Sunandadadi/quay that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants