Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: adding build trigger table (PROJQUAY-6295) #2570

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

bcaton85
Copy link
Contributor

Adds table to view build triggers. Includes the the following:

  • Ability to enable/disable trigger through in-row options
  • Ability to delete trigger
  • Ability to view the trigger credentials
  • Display's and gives option to delete partially intialized triggers, similar to the angular UI
  • Display's triggers that have been automatically disabled and gives a prompt allowing the user to re-enable the trigger

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1c893ba) 70.63% compared to head (5588169) 70.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2570      +/-   ##
==========================================
- Coverage   70.63%   70.63%   -0.01%     
==========================================
  Files         434      434              
  Lines       39885    39885              
  Branches     5172     5172              
==========================================
- Hits        28172    28171       -1     
- Misses      10088    10090       +2     
+ Partials     1625     1624       -1     
Flag Coverage Δ
unit 70.63% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Sunandadadi Sunandadadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bcaton85 bcaton85 merged commit 27cceb1 into quay:master Jan 11, 2024
15 checks passed
Sunandadadi pushed a commit to Sunandadadi/quay that referenced this pull request Jan 15, 2024
Adds the table to view configured build triggers for a repository. Includes enabling/disabling, deletion, viewing credentials, and notifying of automatically disabled triggers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants