-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: add dark mode to see Quay in a new light or lack thereof (PROJQUAY-6570) #2575
Conversation
Signed-off-by: dmesser <dmesser@redhat.com>
Signed-off-by: dmesser <dmesser@redhat.com>
Signed-off-by: dmesser <dmesser@redhat.com>
Signed-off-by: dmesser <dmesser@redhat.com>
Signed-off-by: dmesser <dmesser@redhat.com>
Signed-off-by: dmesser <dmesser@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2575 +/- ##
=======================================
Coverage 70.59% 70.59%
=======================================
Files 434 434
Lines 39856 39856
Branches 5166 5166
=======================================
Hits 28135 28135
- Misses 10102 10104 +2
+ Partials 1619 1617 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sweet |
The PR looks great, one minor comment - can we change tool tip for auto-them to |
Signed-off-by: dmesser <dmesser@redhat.com>
@Sunandadadi done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…Y-6570) (quay#2575) Signed-off-by: dmesser <dmesser@redhat.com>
I bring you dark mode.
Why? Because staring at a bright screen is like staring at the sun. Not cool.
This introduces:
Menu
menu: refactored to use MenuContainer, MenuToggle and Menu with icons like the PatternFly gods intendedLike sunglasses for your screen. See for yourself: