Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: add dark mode to see Quay in a new light or lack thereof (PROJQUAY-6570) #2575

Merged
merged 7 commits into from
Jan 3, 2024

Conversation

dmesser
Copy link
Contributor

@dmesser dmesser commented Dec 29, 2023

I bring you dark mode.

Why? Because staring at a bright screen is like staring at the sun. Not cool.

This introduces:

  • Theme selector: choice is king, we are not dictators
  • Dark mode: easy on the eyes, hard on the boring
  • Auto mode: reflects your desktop's snazzy dark mode setting
  • Menu menu: refactored to use MenuContainer, MenuToggle and Menu with icons like the PatternFly gods intended
  • Persistent choice: browser crashed because too many tabs open? the UI remembers your theme selection, courtesy of local storage

Like sunglasses for your screen. See for yourself:

Screenshot 2023-12-29 at 21 13 12 Screenshot 2023-12-29 at 21 13 00 Screenshot 2023-12-29 at 21 12 45 Screenshot 2023-12-29 at 16 46 40 Screenshot 2023-12-29 at 21 13 28

Signed-off-by: dmesser <dmesser@redhat.com>
Signed-off-by: dmesser <dmesser@redhat.com>
Signed-off-by: dmesser <dmesser@redhat.com>
Signed-off-by: dmesser <dmesser@redhat.com>
Signed-off-by: dmesser <dmesser@redhat.com>
Signed-off-by: dmesser <dmesser@redhat.com>
@dmesser dmesser changed the title ui: add dark mode to see Quay in a new light or lack thereof (PROJQUAY-6569) ui: add dark mode to see Quay in a new light or lack thereof (PROJQUAY-6570) Dec 29, 2023
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (94735bc) 70.59% compared to head (7060b6a) 70.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2575   +/-   ##
=======================================
  Coverage   70.59%   70.59%           
=======================================
  Files         434      434           
  Lines       39856    39856           
  Branches     5166     5166           
=======================================
  Hits        28135    28135           
- Misses      10102    10104    +2     
+ Partials     1619     1617    -2     
Flag Coverage Δ
unit 70.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BillDett
Copy link
Contributor

BillDett commented Jan 2, 2024

sweet

@Sunandadadi
Copy link
Contributor

The PR looks great, one minor comment - can we change tool tip for auto-them to device-based theme instead of browser-based-theme. Browser can be confused with the web browser but in reality it reflects device's mode.

Signed-off-by: dmesser <dmesser@redhat.com>
@dmesser
Copy link
Contributor Author

dmesser commented Jan 3, 2024

@Sunandadadi done

Copy link
Contributor

@Sunandadadi Sunandadadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dmesser dmesser merged commit 2a22ed0 into quay:master Jan 3, 2024
15 checks passed
Sunandadadi pushed a commit to Sunandadadi/quay that referenced this pull request Jan 15, 2024
…Y-6570) (quay#2575)

Signed-off-by: dmesser <dmesser@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants