Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: adding build avatar image size (PROJQUAY-6575) #2580

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

bcaton85
Copy link
Contributor

@bcaton85 bcaton85 commented Jan 3, 2024

Sets the image size for avatars shown in the build history table.

How to test:

  1. Run the Displays build status test in web/cypress/e2e/builds.cy.ts
  2. Verify the row with build id build008 displays the avatar with the correct size

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2a22ed0) 70.59% compared to head (938dfa9) 70.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2580   +/-   ##
=======================================
  Coverage   70.59%   70.59%           
=======================================
  Files         434      434           
  Lines       39856    39856           
  Branches     5166     5166           
=======================================
  Hits        28135    28135           
- Misses      10102    10104    +2     
+ Partials     1619     1617    -2     
Flag Coverage Δ
unit 70.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@harishsurf harishsurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bcaton85 bcaton85 merged commit 7357e31 into quay:master Jan 3, 2024
15 checks passed
Sunandadadi pushed a commit to Sunandadadi/quay that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants