Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marketplace: make sure customer id from api is returned as an int (PROJQUAY-233) #2590

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

Marcusk19
Copy link
Contributor

Make sure when parsing data from user api that the customer id is returned as an integer type. Fixes problem with reconciler where it thinks two of the same id are different.

@Marcusk19 Marcusk19 requested a review from kleesc January 8, 2024 19:33
kleesc
kleesc previously approved these changes Jan 8, 2024
Copy link
Member

@kleesc kleesc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1c893ba) 70.63% compared to head (3e6071a) 70.63%.

Files Patch % Lines
util/marketplace.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2590      +/-   ##
==========================================
- Coverage   70.63%   70.63%   -0.01%     
==========================================
  Files         434      434              
  Lines       39885    39887       +2     
  Branches     5172     5173       +1     
==========================================
+ Hits        28172    28173       +1     
- Misses      10088    10090       +2     
+ Partials     1625     1624       -1     
Flag Coverage Δ
unit 70.63% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Marcusk19 Marcusk19 merged commit 2645176 into quay:master Jan 8, 2024
14 of 15 checks passed
Sunandadadi pushed a commit to Sunandadadi/quay that referenced this pull request Jan 15, 2024
…OJQUAY-233) (quay#2590)

* make sure customer id from api is returned as an int
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants